https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38394
--- Comment #1 from Jonathan Druart <[email protected]> --- Created attachment 174239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174239&action=edit Bug 38394: Remove existing try/catch and say_failure from DB revs On bug 37895 we have failed to propose a solution to encapsulate exceptions and rethrow them. Until this is ready we should not try/catch and so use say_failure from our DB revs. We want to stop the DB update process when something is wrong. In those try/catch we are actually continuing even if something bad happens. As RaiseError is set on the dbh, say_failure statements will never be reached. Test plan: checkout origin/24.05.0 reset_all checkout main + this patch updatedatabase Everything should run fine. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
