https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38413
David Nind <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174311|0 |1 is obsolete| | --- Comment #3 from David Nind <[email protected]> --- Created attachment 174315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174315&action=edit Bug 38413: Batch operations from item search need to POST to not exceed URL length limits Batch item modification and deletion accepts either op="show" or op="cud-show" because sometimes you just have one item and it's saner to GET with one, but sometimes you've selected 961 items from itemsearch and you need to POST to not get hit by Apache's "too long" error. Bug 36630 switched item search from using POST to GET because item search is confusing. It uses a form with a dummy op and then empties out the form and adds back contents, and the CSRF protection changed the dummy op to "cud-show" so it could POST, but didn't notice that the op would be replaced by one that was still "show." The form needs to go back to POST, the dummy contents need a comment saying they are just dummies so nobody else gets fooled, and the JS that replaces the form contents needs to insert a CSRF token and the correct op. Test plan: 1. Without the patch, Search - Item search, search with no criteria so you get hundreds of items 2. Change to Show All entries, then Select visible rows 3. Batch operations - Batch item modification 4. Apache should give you an error about your overly long URL 5. Apply patch and repeat steps 1-3 6. After a long pause while Batch item modification swallows the POST, you should get the batch modification form with all your items. Sponsored-by: Chetco Community Public Library Signed-off-by: David Nind <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
