https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745

--- Comment #65 from David Cook <[email protected]> ---
I'm not super happy with the way the changes have been implemented to
label-item-search.pl, but I can confirm that it appears to work, and that's the
key thing. I'd say that's good enough. Since label-item-search.pl is a fairly
isolated and niche script, I'm not fussed.

I'm going to just double-check the QueryBuilder stuff a bit more... 

I'm also noticing the following warnings with the QA tools:

 WARN   Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 315,
now: 322)

 OK     koha-tmpl/intranet-tmpl/prog/en/modules/labels/result.tt

 WARN   labels/label-item-search.pl
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 53,
now: 63)

 WARN   t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 326,
now: 336)

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to