https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35114
Marcel de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |[email protected] QA Contact|[email protected] |[email protected] |y.org | --- Comment #23 from Marcel de Rooy <[email protected]> --- WARN acqui/basket.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 184, now: 186) - # FIXME The following is wrong + # FIXME The following is wrong <- still true ? remove if patch 35114 fixed it Lets remove that. A fixme that does not tell what is wrong, is wrong on itself. Lets assume we fixed it. And let the author of this fixme stand up if we did not. - $total_tax_excluded += $$line{total_tax_excluded}; + $total_tax_excluded += get_rounded_price($$line{total_tax_excluded}); $foot{$$line{tax_rate}}{total_tax_included} += $$line{total_tax_included}; - $total_tax_included += $$line{total_tax_included}; + $total_tax_included += get_rounded_price($$line{total_tax_included}); You are rounding here IN the loop. Shouldnt you do that outside ? - my $cost_tax_included = $line{unitprice_tax_included} || $line{ecost_tax_included}; - my $cost_tax_excluded = $line{unitprice_tax_excluded} || $line{ecost_tax_excluded}; - $line{total_tax_included} = get_rounded_price($cost_tax_included) * $line{quantity}; - $line{total_tax_excluded} = get_rounded_price($cost_tax_excluded) * $line{quantity}; + $line{total_tax_included} = get_rounded_price($line{ecost_tax_included} * $line{quantity}); + $line{total_tax_excluded} = get_rounded_price($line{ecost_tax_excluded} * $line{quantity}); This looks like a change that does a bit more than fixing the rounding. Why do you ignore $line{unitprice_tax_included} now ? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
