https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38302
--- Comment #6 from Yanjun Li <[email protected]> --- (In reply to Brendan Lawlor from comment #3) > This works, but I think the code block in the patch is partly unnecessary. > > It looks like the code block directly above this patch is really supposed to > be the click handler for this alert with the MSG_CONFIRM_DELETE_LIST, but > the class on the button is different so it never runs. > > The class 'deleteshelf' is used on the opac side, but in shelves_results.tt > the delete button has the class named 'delete-list' instead. > > Before the patch if you git grep -n 'delete-list' you can see that it only > appears in the class on the button in shelves_results.tt > > I don't think the name of the class really matters, but we shouldn't have a > duplicate click handler that does nothing. > > Thanks for finding and fixing this bug. If you resubmit a patch without the > duplicate click handler I will pass QA. Hi Brendan, thank you so much for the explanation. I already deleted the duplicate click handler, and I will pay more attention next time to avoid writing duplicate code. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
