https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30300
--- Comment #25 from Matt Blenkinsop <[email protected]> --- (In reply to Katrin Fischer from comment #19) > 1) Regression (blocker) > > After updating, no MEMBERSHIP_EXPIRY notices will be sent as no patrons will > have the flag in their patron accounts, even if it worked before. > > I don't have a good solution here. Maybe the best we could do is globally > add the flag if MembershipExpiryDaysNotice is set to a value >= 1? I > believe together with the where it would keep the current behavior? I've implemented the above suggestion in the database update file and I've set the bug back to SO so that this can be properly QA checked. This could be quite an intensive update on systems with large numbers of patrons > 2) Documentation (not blocker, but easy) > > It's not clear from the GUI that a "where" option might overwrite the > setting in the patron account. > > I could have a patron with checked patron expiry notice, that is then > "removed" from the list by a where parameter. I think at least a note on the > system preference could help here to fight off general confusion. Added a note to the syspref > 3) Visibility of configuration option (blocker) > > I feel the visiblity of the messaging preference should be dependent on the > MembershipExpiryDaysNotice system preference so libraries have the option to > easily turn this feature off or "keep it invisible" after update. The line in the table is now hidden if the syspref isn't switched on -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
