https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436
--- Comment #45 from Owen Leonard <oleon...@myacpl.org> --- Created attachment 174722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174722&action=edit Bug 38436: Store bKohaColumnsUseNames in data instead of DT's settings DataTable's settings do no longer allow to store custom properties. Here we are passing bKohaColumnsUseNames to the constructor, but we cannot retrieve it later from DT's api. We need to store it in data(). Test plan: 0. Do not apply this patch 1. In _dt_visibility add console.log(settings.bKohaColumnsUseNames); where relevant 2. Open your browser, clear localStorage entries (we want to reach the set_default() code) 3. Hit http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=4 Notice that the value is true then false (displayed once per columns). This is because we are calling _dt_visibility twice: * with the 'settings' we passed to the constructor: 1044 [hidden_ids, included_ids] = _dt_visibility(table_settings, settings, this) * from set_default() where we pass the settings retrieved from DT's api 900 [hidden_ids, included_ids] = _dt_visibility(table_settings, settings, $("#"+settings.nTable.id)); 4. Apply this patch, console.log again and confirm that it's now true. Notice that everything is then buggy... Signed-off-by: Owen Leonard <oleon...@myacpl.org> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
