https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38383
--- Comment #17 from Pedro Amorim <[email protected]> --- Created attachment 174738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174738&action=edit claims tab (In reply to Owen Leonard from comment #16) > (In reply to Pedro Amorim from comment #15) > > The 2nd patch isolates the fix to the > > installer only, why? > > Because we need to review how the '.*-info' tag is used elsewhere to make > sure we don't break something. For example, when I tested the first version > of this patch the "Claims" tab on the checkout page was unreadable. > > When I was customizing variables for the Bootstrap 5 upgrade I did not test > ALL of them because so many were unused. We need to make sure .text-info > works well without making .text-bg-info unusable. I feel like we need to file a follow-up bug with a test plan if this is the case. From my testing, things ((alert-info boxes, etc) generally look better (more contrast) using: $info: $blue-500; I don't see an issue on the claims tab, see attachment - other than the blue being darker - but I'm not familiar with that tab / feature and I'm possibly missing something. I don't fully agree with isolating the fix to the installer because it's not fixing the root issue and is specific styling when this should ideally be global. I think it'd be better if we adopt the correct color globally and then address individual issues as we stumble upon then, instead of having the *-info color be wrong everywhere except the installer. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
