https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37096
--- Comment #6 from Marcel de Rooy <[email protected]> --- Some minor QA comments: my $action = $budget_period_id ne '' ? 'modify' : 'add'; This probably may trigger an uninitialized warning. Shouldnt we fix by adding a fallback here: my $budget_period_id = $input->param('budget_period_id'); if ( $budget_period_startdate eq '' || $budget_period_enddate eq '' ) { Same here. Add fallback to: my $budget_period_startdate = $input->param('budget_period_startdate'); my $budget_period_enddate = $input->param('budget_period_enddate'); EXIT_IF: { [etc] $op = 'else'; last EXIT_IF; Using last (goto) is not the best programming style. And it seems easy to adjust the next if / else to prevent needing it. + [% IF failed_add_validate %] I wonder if adding something with no start- or enddate here would be more clear? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
