https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36798

--- Comment #19 from Katrin Fischer <[email protected]> ---
(In reply to Janusz Kaczmarek from comment #18)
> (In reply to Katrin Fischer from comment #17)
> > (In reply to Katrin Fischer from comment #16)
> > > I have to admit when we talked about this at the hackfest, I was thinking
> > > about a slightly different solution, more in line with how the system
> > > preferences *NumbersPreferPhrase work. They work on the GUI level, 
> > > changing
> > > the index used in the drop-downs and search options.
> > > 
> > > With this patch, whenever I use the index "isbn" in "Expert search" it 
> > > will
> > > also be turned into isbn-all, if I understand how this works correctly. 
> > > Can
> > > you confirm?
> > 
> > *ping*
> 
> I am sorry I missed this.
> 
> I am a bit lost.  My intention and understanding is that the patch works
> exactly as you described for *NumbersPreferPhrase.  If
> SearchCancelledAndInvalidISBNandISSN is on, the patch adds '-all' to
> isbn/issn search-field-name (cf. corrections in QueryBuilder.pm), thus
> changing the search-field (in Zebra-terms you would say 'index', but since
> it is only for ES 'search-field' is better ; 'index' is completely different
> thing in ES).
> 
> Are you experiencing different behavior?

It works, but the implementation is very different. With *NumbersPreferPhrase
we only change templates and use another index when a specific search option is
selected. Your patch works on a different level. :) But it's ok, we leave it
like that.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to