https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38523
Bug ID: 38523
Summary: Simple quote in ILL standard form JS can break
translations
Change sponsored?: ---
Product: Koha
Version: Main
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: I18N/L10N
Assignee: [email protected]
Reporter: [email protected]
QA Contact: [email protected]
CC: [email protected], [email protected]
Follow-up of Bug 36221.
In Koha/ILL/Backend/shared-includes/shared.js
'" name="custom_key" placeholder="'+__('key')+'">' +
' ' +
'<input type="text" id="custom-value" name="custom_value" class="' +
( opac ? 'form-control input-fluid custom-field-input' : '') +'"
placeholder="'+__('value')+'"> ' +
'<button type="button" class="btn btn-danger btn-sm ' +
'delete-new-field">' +
'<span class="fa fa-trash-can"></span> ' +
__('Delete') +
[...]
$('#custom-warning').text(__("The name '%s' is not
permitted").format(val)).show();
-------
This will need to be tested once bug 38340 has patches.
For now stuff is not translatable but once it is, it's expected the JS can
break if the translated string contains a simple quote.
-------
xt/single_quotes.t doesn't catch it because the test only searches in
koha-tmpl/opac-tmpl/bootstrap/en/
koha-tmpl/intranet-tmpl/prog/en/
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
