https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38411
Victor Grousset/tuxayo <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Status|Needs Signoff |Failed QA --- Comment #2 from Victor Grousset/tuxayo <[email protected]> --- Hola, thanks for finding out that the multiple items case wasn't covered :o And thanks for the fix :) At first I though adding an alert() would be a problem, since we are phasing them out since years: https://wiki.koha-community.org/wiki/Interface_patterns#Errors_and_messages But here it's a bit different. There is already an alert() just above in addItem(). So the actual issue is the perfect duplication of code. Almost perfect. I think it we should keep __() for translation and not switch to _(). Unless there is something warranting switching (I don't remember if _() actually works in our JS files) If you can and want to improve the UX by migrating to proper error messages as shown in the wiki, feel free to do so. Here or in a follow-up ticket depending if you feel that's too much changes. And if not it's fine to "add" an alert() because it's not really added if it's from the single item case already there with the code not duplicated. Feel free if you have questions, here or in https://chat.koha-community.org/ -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
