https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355
--- Comment #133 from Matt Blenkinsop <[email protected]> --- (In reply to Jonathan Druart from comment #130) > There are so many things to say here, but I don't have time right now for a > full QA review... > > Just let say the main points that shall have been raised by QA: > > 1. Missing tests! > > 2. Useless lines > > + my @messages; > > +use Net::FTP; > > 3. Plugin hook added without being advertised (wiki, kitchenzink?) > > + 'before_orderline_create', > > 4. Code for acq not in Koha::Acquisition? > > 5. controller poorly written and not following standard > admin/marc_order_accounts.pl > * useless use statements > * 51 my $crypt = Koha::Encryption->new; wtf? > * values for '$op' not following "standard" > * no error handling, no user messages/alerts > > > Everybody wants their stuffs pushed, but we really need more eyes and spend > more time on QA IMO. > > I have been fighting for years to clean the code, but what's the point if we > don't enforce the quality and prevent new legacy code to be pushed? Looking at these, will add a follow-up bug -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
