https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268
Matt Blenkinsop <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com --- Comment #7 from Matt Blenkinsop <[email protected]> --- Started having a look at this for QA and everything works as advertised but I'm hesitant to pass QA. This fixes the existing cases but I worry about what happens the next time someone who isn't aware of this bug adds a call to confirmModal - does it not make more sense to move the removal of the existing modal up a level into the confirmModal function itself so that it is handled each time without the need to implicitly handle it in each individual callback? I'm adding an alternate patch for testing that does this - let me know your thoughts and if the behaviour works as expected -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
