https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268
Owen Leonard <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174995|0 |1 is obsolete| | Attachment #175311|0 |1 is obsolete| | --- Comment #13 from Owen Leonard <[email protected]> --- Created attachment 175325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175325&action=edit Bug 38268: Callers of confirmModal need to remove the modal as the first step in their callback function Templates that use confirmModal to show a pretty confirm() need to remove the modal in their callback function, or they are at risk of having the first callback called for subsequent calls that think they will get their own callback called. opac-user.tt is already fixed, opac-shelves.tt is currently affected, and opace-suggestions.tt, opac-tags.tt, and sco/sco-main.tt are at risk of being affected if anyone adds another confirmModal caller. Test plan: 1. Without the patch, open the OPAC, log in, search for something that will return several results 2. Select all - Add to list - New list 3. Lists - {your list name} 4. Click the checkboxes for the first two items 5. Instead of clicking Remove from list, accidentally click Delete list 6. In the confirmation popup, realize it was a mistake and click No, do not delete 7. Click Remove from list 8. Poof, your whole list is gone 9. Apply patch 10. Repeat steps 1-7, but instead of the whole list being deleted, see that only the selected two items were removed 11. Now intentionally click Delete list and click Yes, delete, you'll see that it is deleted rather than getting a message about nothing being removed like you would have gotten without the patch if you started by removing an item 12. On any bib detail page, click Add tag(s) and add one 13. Your account - Tags, check the checkbox for the tag, Remove selected tags, Yes, delete tag and verify that it was deleted 14. Purchase suggestions - New purchase suggestion, fill in a title and submit your suggestion, click the checkbox for your suggestion, Delete selected, Yes, delete suggestion and verify it was deleted 15. In the staff interface, find and copy the barcode for any item that can be checked out, then go to /cgi-bin/koha/sco/sco-main.pl with the OPAC hostname and port, not the staff, and log in 16. Paste the barcode in the input, click Submit, then click Finish, and in the confirmation popup click Print recept and end session, and verify that it tries to print Sponsored-by: Chetco Community Public Library Signed-off-by: Victor Grousset/tuxayo <[email protected]> Signed-off-by: Owen Leonard <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
