https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38664
--- Comment #21 from David Cook <[email protected]> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #19) > We shouldn't see 'tidy' commits. Those should be FQA most of the time. And > the author should deal with tidying and squashing. > > Sometimes the tidy is a bit more complex and justifies an extra commit, but > that's the exception I'd say. Personally, I prefer having a separate tidy commit, since it makes it clear that the change to the existing code is due only to the tidy. I find it makes it easier to review code, especially on the Bugzilla UI, which is typically my first step for code review. > I still hate it that KTD tries to manipulate my git clone on startup BTW. Yeah I don't love it either. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
