https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38720

            Bug ID: 38720
           Summary: HTML1 no longer valid? TT tags can be present in HTML
                    without breaking the translator tool
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: [email protected]
          Reporter: [email protected]
        QA Contact: [email protected]

We have the following coding guidelines:

```
HTML1: Template Toolkit markup inside HTML

Avoid [% IF %] inside tags because the translation tools try to read the
templates as straight HTML and most TT comments inside tags probably
confuse/break them. The most common example of an incorrect construction:

<option value="1" [% IF (selected) %] selected="selected" [% END
%]>Yes</option>

This must be written this way:

[% IF (selected) %]
 <option value="1" selected="selected">Yes</option>
[% ELSE %]
 <option value="1">Yes</option>
[% END %]
```

Everybody (should) know about it, and we are all aware it must not be done like
that.
But... I will need it for bug 38664 and I have decided to have a look at fixing
it.

However I have not managed to break anything!

I did introduce TT tags within HTML tags, but the strings are correctly picked
and the translated templates is perfectly generated.

What am I missing here? Did we finally fix this long-standing problem without
knowing it?

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to