https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37882
Emily Lamancusa (emlam) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |emily.lamancusa@montgomeryc | |ountymd.gov QA Contact|[email protected] |emily.lamancusa@montgomeryc |y.org |ountymd.gov --- Comment #4 from Emily Lamancusa (emlam) <[email protected]> --- Ooh, this is a great addition! Since this is a string patch that is partly for users, I am going to nitpick the strings a bit, though... Do the classes need to exactly match the reason codes passed to the template? If not, I'd argue for the following changes for better consistency: 1. The classes should match our vocabulary conventions (for example, toomanyholdstoday instead of toomanyreservestoday) 2. Consistent use of underscores in class names These don't have to be a blocker if there's a good reason to keep it as-is, but if we can have more consistency that will make it easier for users to write their own customizations, then I think we should. Setting to FQA for feedback. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
