https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38712
Emily Lamancusa (emlam) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov Status|Signed Off |Failed QA --- Comment #12 from Emily Lamancusa (emlam) <[email protected]> --- Thanks for submitting the bug report and patch, Chloe! For changes to .pm files, we also require unit tests (see https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL17:_Unit_tests_are_required and https://wiki.koha-community.org/wiki/Unit_Tests). It seems odd to me to make a sorting change in pm files instead of at the script or templating level, so you might want to look into that possibility (if you haven't already) before investing time on unit tests. I'm afraid I'm not familiar enough with My Lists or these parts of the code to comment on that with any certainty, though. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
