https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #11 from Katrin Fischer <[email protected]> --- 1) Capitalization + (10, 'void_payment', 'Voiding Payments'), + $dbh->do(q{ + INSERT IGNORE permissions (module_bit, code, description) VALUES + (10, 'void_payment', 'Voiding Payments') Etc. For Koha we have decided to only upper-case names and the first word. Please check coding guidelines for more information. 2) This is missing a server side check. I believe we also need to check for this permission server side and maybe in the API. I would be OK to handle the API on a separate bug if there is no veto, but would like to see a re-worked patch with fixed capitalization and the server side check looked into. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
