https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19113

David Nind <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
             Status|Needs Signoff               |Failed QA

--- Comment #15 from David Nind <[email protected]> ---
I had a go at testing, but I notice no difference before and after the patch is
applied.

I don't really understand what has actually changed here, or what the issue is
that this fixes - since I can't replicate the issue.

Testing notes (using KTD)
=========================

Before the patch
----------------

1. The latest/highest value barcode in the sample data is 39999000019193.
2. Set the autoBarcode system preference to "generated in the form
<branchcode>yymm0001".
3. Add a new item to a record and click in the "p - Barcode field:":
   ==> Result: the barcode generated is CPL24120001
4. Add another item to the record and click in the "p - Barcode field":
   ==> Result: the barcode generated is CPL24120002

I can't replicate the problem originally reported:

"The regexp for the value builder 'hbyymmincr' doesn't allow for numerics in
the branchcode, so the nextnum found is always 0 and multiple Add always
generate the same barcode."

The results are what I expected - the barcode in the new pattern increments by
1 for new items, CPL24120001, CPL24120002, CPL24120003, and so on.

If I delete all the barcodes (1. Access the database: koha-mysql kohadev 2.
Remove all the barcodes: update items set barcode=NULL;) and add a manual
barcode, such as 35, the barcodes still increment as expected from CPL24120001.

If I use the "Add item", "Add and duplicate", and "Add multiple copies of this
item", and also add n item to another record, I can't replicate the issue as
described.

After the patch
---------------

I reset everything so that the changes made to the data before the patch are
gone.

1. The latest/highest value barcode in the sample data is 39999000019193.
2. Set the autoBarcode system preference to "generated in the form
<branchcode>yymm0001".
3. Add a new item to a record and click in the "p - Barcode field:":
   ==> Result: the barcode generated is CPL24120001
4. Add another item to the record and click in the "p - Barcode field":
   ==> Result: the barcode generated is CPL24120002

I noticed no change in behavour or results.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to