https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34971

--- Comment #4 from David Nind <[email protected]> ---
Created attachment 175972
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175972&action=edit
Screenshots - Close serials permissions

I had a go at testing (using koha-testing-docker) on 22.11.22 and on main.

What I found:
1. On 22.11.22:
   - there is a "Close" button only on the serial collection page
   - you can close a serial
   - I couldn't get the patch to apply on 22.11.22 (I got a weird error 
     I've never seen before), so I couldn't test the patch
2. On main:
   - same as 22.11.22, there is "Close" button only on the serial
     collection page
   - you can close a serial
   - after the patch (which applies on main), the "Close" button is still there 
     on the serial collection page
   - if you click "Close" you get the login screen with "Error: You do not have
     permission to access this page.”

I've attached a document with screenshots, hopefully that will make it easier
to see what I saw.

I've changed to Failed QA, as:
- It isn't fixed on main.
- I think the "Close" button shouldn't be there on the serial collection page
if you don't have the correct permissions.
- As an aside, I don't think the "Manage frequencies" and "Manage numbering
patterns" menu items should be shown if the staff patron doesn't have the
correct permissions (this should probably be another bug).

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to