https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38813
Lucas Gass (lukeg) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176098|0 |1 is obsolete| | --- Comment #3 from Lucas Gass (lukeg) <[email protected]> --- Created attachment 176101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176101&action=edit Bug 38813: Make the 'curbside pickups' tab display selected if so This patch fixes a wrong condition check in `usermenu.inc` for determining if the tab should be active. It currently checks for `ermview`, probably a copy and paste error. This patch adds a new `curbside_pickups_view` parameter that is passed instead. Note: I tidied the code block I changed, inline to avoid extra commits. To test: 1. Enable the `CurbsidePickup` system preference 2. Log into the OPAC => SUCCESS: There's a 'Curbside pickups' tab 3. Click on the tab => SUCCESS: The 'Curbside pickups' section gets displayed => FAIL: The tab remains inactive 4. Apply this patch 5. Restart plack: $ ktd --shell k$ koha-plack --restart kohadev 6. Repeat 3 => SUCCESS: The 'Curbside pickups' section gets displayed => SUCCESS: The tab is rendered as active 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <[email protected]> Signed-off-by: Lucas Gass <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
