https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31487

Andrew Fuerste-Henry <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #9 from Andrew Fuerste-Henry <[email protected]> ---
This needs to use GetPreparedLetter. It also needs to include a default notice.

GetPreparedLetter would allow this to determine which branch to use, rather
than asking for a branch in the cron. Specifying a branchcode in the cron
really will not work for a variety of consortial setups. We need this to use
something more like the overdue cron's --frombranch  flag, which tells koha to
use either the issuing library or the owning library.

The "--mail" flag seems superfluous if adding "--mail" means "--code" and
"--branch" are then required.

Does this currently have any ability to pull in variables, like the patron
name? It does not seem to, and that seems like a minimum functionality
requirement.

Ultimately, this wants: 
- to be a patron messaging preference
- to generate a Print notice when the patron lacks an email address
- to allow SMS message transport stuff
- to allow digests

I think some of that would be accomplished by using GetPreparedLetter. The rest
could be follow-ups.

(In reply to Thibaud Guillot (thibaud_g) from comment #8)
> Created attachment 176318 [details] [review]
> Bug 31487: Add an option to send by mail longoverdue items to borrowers
> 
> Test plan:
> 1) You must have longoverdue items to one or many borrowers
> 2) You must create a notice template (Notices & slips section)
> 3) You can run the script misc/cronjobs/longoverdue.pl manually without
> --mail option first (see -h or --help for more info about the script)
> 4) You must see an output with some longoverdues (step 1 required)
> 5) Now you can run the script with --mail option but like its specify in
> "help" option you must add option --code="" (relative to your code
> template) and --branchcode="".
> 6) Normally you will see after the classic output a new block with
> emails added to the message queue and it will be sent on the next
> misc/cronjobs/process_message_queue.pl script iteration
> 
> Sponsored by: BibLibre

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to