https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38713
--- Comment #3 from Jonathan Druart <[email protected]> --- (In reply to Phil Ringnalda from comment #2) Thanks a lot, Phil! > One blocker to signing off: > > https://gitlab.com/joubu/Koha/-/commit/ > 4ef2233f4b9787ee533ce3ff84348575ba0cd591 leaves the <form> for the > not-multi-hold case unclosed Fixed in "Bug 38713: (follow-up) reserve/request.tt" (will squash later) > Two minor quibbles: > > In > https://gitlab.com/joubu/Koha/-/commit/ > 51746c7dda9d832c0efd91e66e59aac65e4e76ed the stray </em> should just be > removed, .breadcrumb-item is font-style: italic so it's not needed Ok but not something for here. > In > https://gitlab.com/joubu/Koha/-/commit/ > 02e97eba3b88fb96bb94b3131722a94fa3fbed57 I think the intention of the > original was to wrap that stuff in a block, not to put space above and below > - while it would look better to me with some space below (and not above) I > think the fix for structure is just to wrap it in a <div> rather than a <p> It was the easiest, and it looks identically before and after. IIRC (didn't retest now) with a div the display was not the same (could be achieve with styling ofc). Happy to adjust if you have a better fix. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
