https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38528
--- Comment #16 from Pedro Amorim <[email protected]> --- Thanks for the tests patch Batptiste. I think those make sense, but I added additional tests for the marcfield mode 'get' specifically. (In reply to Baptiste Wojtkowski (bwoj) from comment #11) > @Pedro Amorim I can't get the purpose of the add in additionnal_fields.pm, > is it supposed to prevent from creating a value if the marc field is empty ? > Is it what we want ? set_additional_fields expects a "get" marcfield to exist, but its value is irrelevant as it's going to be assigned the data that exists in the configured marc field. Before my patch here, the marcfield is never sent to set_additional_fields, because it was being skipped in prepare_cgi_additional_field_values as was empty. After my patch here, the "get" marcfield will now exist even if empty, and set_additional_fields will consider it and assign the value from marcfield as expected. But set_additional_fields will still not add 'empty' values in the database. (In reply to Jonathan Druart from comment #10) > Can we have a test please? We have now. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
