https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34756
Emily Lamancusa (emlam) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|[email protected] |emily.lamancusa@montgomeryc |y.org |ountymd.gov Status|Signed Off |Failed QA --- Comment #7 from Emily Lamancusa (emlam) <[email protected]> --- I really like this idea! On a first review the code generally looks good. There are just a few things I think need to be clarified/adjusted: First, I think the wording on the checkbox could be adjusted to make it a little clearer to library staff what will happen, though. Could it be a drop-down instead of a checkbox? Something like: "Yes - Cancel transfer and keep the item here" "No - Leave the item in transit" Second, from request.pl: + my $transfer = $input->param("transfer-cancel") ? "1" : "0"; my $hold = Koha::Holds->find($reserve_id); + + if( $transfer ) { + warn($hold->item()->get_transfer); + $hold->item()->get_transfer->cancel( { reason => 'Manual', 'force' => '1' } ); + } Why the warn? Also, I think it would be clearer to call the variable $transfer_cancel instead of $transfer, since that's really what it's about at this point in the code. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
