https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39001
Bug ID: 39001
Summary: Language list is displayed in wrong order
(getLanguages doesn't sort it, the order is UB)
Change sponsored?: ---
Product: Koha
Version: Main
Hardware: All
OS: All
Status: NEW
Severity: trivial
Priority: P5 - low
Component: OPAC
Assignee: [email protected]
Reporter: [email protected]
QA Contact: [email protected]
Caught by unit tests added in Bug 38646, but it's not a regression of that bug.
It seems that the list of languages from getLanguages is not ordered in any
way, instead it relies on the implementation detail of the database server in
terms of the order it returns things in. Indeed even before that bug was
merged, in Koha 24.11 and 24.05, one can observe in OPAC -> Advanced search ->
Language, that the order of languages is indeed a bit wrong (for example: amh,
grc, ara -- Old Greek (grk) has nothing starting with "a", so it has no
business being this high in the list).
The solution in principle is simple, just order the returned language list (TBD
what to order it by: by language code, by English name, by effective final
display name????). It's also TBD whether getLanguages should sort it itself, or
whether places that display languages, such as `/cgi-bin/koha/opac-search.pl`,
should actually be doing the ordering in preferred fashion.
In any case, the tests at t/db_dependent/Languages.t fail due to wrong order
after some MariaDB update, so current order is undefined behavior.
Also if we select to change the behavior of getLanguages, then it'll be
trickier to backport it, since dependent Bug 38646 is enhancement due to slight
change of behavior. But the backporter could easily adjust the SQL query there
to make the lines "THEN CONCAT(" be selected with removing the conditional, so
that the language list is always appended in parentheses (old behavior).
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
