https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38180

Lucas Gass (lukeg) <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #172922|0                           |1
        is obsolete|                            |

--- Comment #4 from Lucas Gass (lukeg) <[email protected]> ---
Created attachment 177401
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177401&action=edit
Bug 38180: Don't show label if 520 ind1=8 (MARC21)

This patch amends the display constant for field 520 if the first
indicator is set to 8. According to MARC21 documentation
(https://www.loc.gov/marc/bibliographic/bd520.html), the field's
labels depend on the value of indicator 1.

First Indicator Second Indicator
Display constant controller
empty - Summary
0 - Subject
1 - Review
2 - Scope and content
3 - Abstract
4 - Content advice
8 - No display constant generated

Prior to this patch, a 520 field with ind1 = 8 is displayed as
'Summary'. After this patch, there is no label.

To test:
1. Create or edit a record, and add 7 x 520 tags:
   - Add one 520 tag with no value in ind1, enter 'Summary' in 520$a
   - Add one 520 tag with 0 in ind1, enter 'Subject' in 520$a
   - Add one 520 tag with 1 in ind1, enter 'Review' in 520$a
   - Add one 520 tag with 2 in ind1, enter 'Scope and content' in 520$a
   - Add one 520 tag with 3 in ind1, enter 'Abstract' in 520$a
   - Add one 520 tag with 4 in ind1, enter 'Content advice' in 520$a
   - Add one 520 tag with 8 in ind1, enter 'No display constant
     generated' in 520$a

2. View the record in the staff interface
   --> The labels should be
       - 'Summary' for the field that contains 'Summary' (OK)
       - 'Subject' for the field that contains 'Subject' (OK)
       - 'Review' for the field that contains 'Review' (OK)
       - 'Scope and content' for the field that contains 'Scope and
         content' (OK)
       - 'Abstract' for the field that contains 'Abstract' (OK)
       - 'Content advice' for the field that contains 'Content advice'
         (OK)
       - 'Summary' for the field that contains 'Subject' **(NOT OK)**

3. View the record in the OPAC
   --> The labels should be
       - 'Summary' for the field that contains 'Summary' (OK)
       - 'Subject' for the field that contains 'Subject' (OK)
       - 'Review' for the field that contains 'Review' (OK)
       - 'Scope and content' for the field that contains 'Scope and
         content' (OK)
       - 'Abstract' for the field that contains 'Abstract' (OK)
       - 'Content advice' for the field that contains 'Content advice'
         (OK)
       - 'Summary' for the field that contains 'Subject' **(NOT OK)**

4. Apply patch

5. Repeat step 2 (view the record in the staff interface; make sure to
   refresh the page)
   --> The labels should be
       - 'Summary' for the field that contains 'Summary' (OK)
       - 'Subject' for the field that contains 'Subject' (OK)
       - 'Review' for the field that contains 'Review' (OK)
       - 'Scope and content' for the field that contains 'Scope and
         content' (OK)
       - 'Abstract' for the field that contains 'Abstract' (OK)
       - 'Content advice' for the field that contains 'Content advice'
         (OK)
       - Nothing for the field that contains 'Subject' (OK!!)

6. Repeat step 3 (view the record in the OPAC; make sure to refresh the
   page)
   --> The labels should be
       - 'Summary' for the field that contains 'Summary' (OK)
       - 'Subject' for the field that contains 'Subject' (OK)
       - 'Review' for the field that contains 'Review' (OK)
       - 'Scope and content' for the field that contains 'Scope and
         content' (OK)
       - 'Abstract' for the field that contains 'Abstract' (OK)
       - 'Content advice' for the field that contains 'Content advice'
         (OK)
       - Nothing for the field that contains 'Subject' (OK!!)

https://bugs.koha-community.org/show_bug.cgi?id=38081
Signed-off-by: esther <[email protected]>
Signed-off-by: Lucas Gass <[email protected]>

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to