https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054

David Liddle <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #59 from David Liddle <[email protected]> ---
(In reply to Jonathan Druart from comment #55)
> (In reply to David Cook from comment #54)
> > So then I'm thinking of a DB table like "ui_staff" where these
> > "staff_header_color" and "staff_bg_color" are either text columns OR they're
> > object keys in a JSON column. 
> > 
> > --
> > 
> > But... I think you could argue that a new DB table might be premature since
> > right now you're only proposing 1 new column. Fair enough.
> 
> I think this is the solution.
> 
> We need a library.library_css that would be a JSON version of CSS rules
> specific to the library.
> We allow edition via a "css" form that could be on the edit library view,
> with some attributes and color picker.
> 
> It will build a solid ground for future changes.
> 
> Example: https://snipboard.io/WVSrnt.jpg
> 
> It does not seem to be a lot of work, but allow for way more flexibility
> than introducing the "1 DB column per css rule/color" pattern.

Hi there, all... I just want to bring something to your attention. The term
"CSS" is being used here when only the color scheme is under discussion. Color
scheming is but ONE function of CSS. If you create a table to manage ONLY the
color scheme -- be it 'by way of' CSS or some other mechanism -- then I suggest
that "css" not be part of the table name. That would be misleading. If,
however, the proposed table would be used for all manner of stylings to be
applied by CSS -- and ONLY by CSS -- then the suggested name would be
appropriate.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to