https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271

--- Comment #40 from Victor Grousset/tuxayo <[email protected]> ---
Comment on attachment 172924
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172924
Bug 36271: Add circulation rules for booking

Review of attachment 172924:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=36271&attachment=172924)
-----------------------------------------------------------------

::: Koha/REST/V1/Bookings.pm
@@ +104,5 @@
> +                'noBookingsAllowed' => 'Bookings are not allowed according 
> to circulation rules',
> +                'tooManyBookings' => sprintf('Patron has reached the maximum 
> of booking according to circulation rules : %s maximum (%s)', $limit, $rule),
> +                'tooLongBookingPeriod' => sprintf('Booking period exceed 
> booking period limit according to circulation rules : %s day(s)', $limit),
> +                'bookingPeriodNotValid' => sprintf('Booking period must be 
> valid'),
> +                'ageRestricted' =>  "Age restricted",

It's not translatable and it can't be due to being in a .pm.
https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML2:_HTML_inside_Perl_scripts

A way (unless there something better) would be to pass the tokens
(noBookingsAllowed/tooManyBookings/etc) directly and some variables that will
be needed to construct the error message client side.

Here the rule wouldn't have been translatable either, so that will also allow
that.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to