https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17506
--- Comment #20 from Victor Grousset/tuxayo <[email protected]> --- Comment on attachment 176185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176185 Bug 17506: (follow-up) Check IssueLog syspref when logging offline checkout Review of attachment 176185: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17506&attachment=176185) ----------------------------------------------------------------- ::: C4/Circulation.pm @@ +4301,4 @@ > ); > > logaction("CIRCULATION", "ISSUE", $issue->{borrowernumber}, > $itemnumber) > + if C4::Context->preference("IssueLog"); The preference check before was correct. Here we just did a forced check-in/return [1] but we are logging a checkout. So it's the logaction() call that should have been flipped and not the syspref check. [1] because we are just after MarkIssueReturned() Which doesn't log so the check-in needs to be logged. And the actual checkout will done be just after with AddIssue(). Which includes logging. I got confused a few times when looking at this so I'm not 100% sure. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
