https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39115
Victor Grousset/tuxayo <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #34 from Victor Grousset/tuxayo <[email protected]> --- > The script QA doesn't complain but that will be a ticket I'll open for the QA > tools. Oh no, actually the QA script not complaining about legit tidy issues is partially from these patches! --on main:------------------------------ FAIL koha-tmpl/intranet-tmpl/js/i18n.js FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl /kohadevbox/koha/koha-tmpl/intranet-tmpl/js/i18n.js` OK koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt FAIL mainpage.pl FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl /kohadevbox/koha/mainpage.pl` ----------------------- It was already missing intranet-main.tt. But it was working for the .pl and .js files. So that's a regression these patches will be introducing :/ ------------------------ Testing details in case I missed something: ----QA tools is on latest commit in my KTD--------------------------------- commit 11502a72aa1c77f9c981299a81a6d434e54e2808 Issue #90: Fix prettierrc.js filename -----name and diff of the files I untidied------------------------ diff --git a/koha-tmpl/intranet-tmpl/js/i18n.js b/koha-tmpl/intranet-tmpl/js/i18n.js index 6eb7e86a8d..d6a7ef3f5b 100644 --- a/koha-tmpl/intranet-tmpl/js/i18n.js +++ b/koha-tmpl/intranet-tmpl/js/i18n.js @@ -46,6 +46,6 @@ function __np(msgctxt, msgid, msgid_plural, count) { return Koha.i18n.gt.npgettext(msgctxt, msgid, msgid_plural, count); } -function __npx(msgctxt, msgid, msgid_plural, count, vars) { + function __npx(msgctxt, msgid, msgid_plural, count, vars) { return Koha.i18n.expand(__np(msgctxt, msgid, msgid_plural, count), vars); } diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt index 91172dac2a..69faa7ff92 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt @@ -340,6 +340,6 @@ }); }); </script> -[% END %] + [% END %] <!-- the main div is closed in intranet-bottom.inc --> [% INCLUDE 'intranet-bottom.inc' %] diff --git a/mainpage.pl b/mainpage.pl index 87f784631f..1d948089aa 100755 --- a/mainpage.pl +++ b/mainpage.pl @@ -153,7 +153,7 @@ if ( C4::Context->preference('PatronSelfRegistrationAlert') ) { ); } -$template->param( + $template->param( pendingcomments => $pendingcomments, pendingtags => $pendingtags, pending_borrower_modifications => $pending_borrower_modifications, -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
