https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188

Katrin Fischer <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|[email protected] |[email protected]
                   |y.org                       |
             Status|Passed QA                   |Patch doesn't apply

--- Comment #36 from Katrin Fischer <[email protected]> ---
I am sorry, but the auto_rebase.pl script couldn't quite deal with this patch
set. Can you please verify?

With latest ktd and images:
perl misc/devel/auto_rebase.pl --bugzilla 36188

I also have the same errors when I try to tidy manually using
misc/devel/tidy.pl filename.

There is in deed a closing div in line 217 of opac-shelves.tt that loosk not
quite right.

kohadev-koha@kohadevbox:koha(main)$ perl misc/devel/auto_rebase.pl --bugzilla
36188
Creating a temporary branch 'bug_36188-tmp'...
Guessing a date to use from bugzilla's bug 36188
First patch from this bug was applied at 2025-01-17T14:56:30Z
Resetting HEAD to where origin/main was at 2025-01-17T14:56:30Z (commit
78c4bc89b190eff44e9bc04d52130c143a61ecac)
Applying patches using git bz
Creating a new branch 'bug_36188-rebased' starting at the end of the tidy
commits...
Getting commit list from branch 'bug_36188-tmp'...
No number of commits passed, trying to guess it...
Found 3 commits to process
Processing 3 commits...
        Processing commit 32ccde93066... (1/3)
                Processing file
koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt... (1/3)
Tidying file 1/1
(koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt)
[error] koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt:
SyntaxError: Unexpected closing tag "a". It may happen when the tag has already
been closed by another tag. For more info see
https://www.w3.org/TR/html5/syntax.html#closing-elements-that-have-implied-end-tags
(3:49)
[error]   1 |
[error]   2 |                                                 #~294~#
[error] > 3 |                                                 </a>
[error]     |                                                 ^^^^
[error]   4 |                                              at /tmp/kg4WuwqfoU
line 112.

Some files cannot be tidied:
        * koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
[error] koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt:
SyntaxError: Unexpected closing tag "a". It may happen when the tag has already
been closed by another tag. For more info see
https://www.w3.org/TR/html5/syntax.html#closing-elements-that-have-implied-end-tags
(3:49)
[error]   1 |
[error]   2 |                                                 #~294~#
[error] > 3 |                                                 </a>
[error]     |                                                 ^^^^
[error]   4 |                                             
                Processing file
koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/tables/shelves_results.tt...
(2/3)
Tidying file 1/1
(koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/tables/shelves_results.tt)
                Processing file virtualshelves/shelves.pl... (3/3)
Tidying file 1/1 (virtualshelves/shelves.pl)
                Committing changes...
        Processing commit 800ff7887ee... (2/3)
                Processing file
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt... (1/2)
Tidying file 1/1 (koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt)
[error] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt: SyntaxError:
Unexpected closing tag "div". It may happen when the tag has already been
closed by another tag. For more info see
https://www.w3.org/TR/html5/syntax.html#closing-elements-that-have-implied-end-tags
(4:25)
[error]   2 |                         #~162~#
[error]   3 |                         #~195~#
[error] > 4 |                         </div>
[error]     |                         ^^^^^^
[error]   5 |                      at /tmp/kg4WuwqfoU line 112.

Some files cannot be tidied:
        * koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
[error] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt: SyntaxError:
Unexpected closing tag "div". It may happen when the tag has already been
closed by another tag. For more info see
https://www.w3.org/TR/html5/syntax.html#closing-elements-that-have-implied-end-tags
(4:25)
[error]   2 |                         #~162~#
[error]   3 |                         #~195~#
[error] > 4 |                         </div>
[error]     |                         ^^^^^^
[error]   5 |

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to