https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868

--- Comment #27 from Victor Grousset/tuxayo <[email protected]> ---
Comment on attachment 177762
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177762
Bug 36868: Add logic for OPAC

Review of attachment 177762:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=36868&attachment=177762)
-----------------------------------------------------------------

::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
@@ +1077,5 @@
>      [% INCLUDE 'datatables.inc' %]
>      <script>
> +        [% IF successful_holds && 
> Koha.Preference('AutoDeleteFromCartWhenHoldPlaced').grep('opac').size %]
> +            [% FOREACH success IN successful_holds.split('\|') %]
> +                delSingleRecord('[% success | html %]');

Having a function call dropped in a <script> of page it likely the cause.
Such technique need the call to be idempotent.
Like making the count always be calculated from the cart content instead a
separate variable? Even without going as far as such of a refactor, it looks
like a bug that passing an already removed record would trigger the correct
message but still decrement the count.

Or somehow having the call only done once. (self deleting <script> tag? 😆)

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to