https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38336
Andreas Roussos <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #17 from Andreas Roussos <[email protected]> --- Hi Mathieu! I tried to test this today using K-T-D but the patch no longer applies cleanly on the current main branch (commit 8abf287e6d). More specifically: 1) there are trailing whitespace warnings, these appear to come from: --- a/installer/data/mysql/mandatory/auth_val_cat.sql +++ b/installer/data/mysql/mandatory/auth_val_cat.sql @@ -56,8 +56,7 @@ INSERT IGNORE INTO authorised_value_categories( category_name, is_system ) INSERT IGNORE INTO authorised_value_categories( category_name ) VALUES ('ETAT'), ('CAND'), - ('COUNTRY'), - ('TYPEDOC'), + ('COUNTRY'), <--------------- Here are the two extra spaces ('qualif'); 2) there are merge conflicts in two files: C4/Koha.pm t/lib/TestBuilder.pm Which are most likely related to the mass tidying of the codebase which was recently committed to main (Bug 38664). Also, I think the test plan would be a bit easier to read if it used a hanging indent, as per the Wiki instructions at: https://wiki.koha-community.org/wiki/Commit_messages#Test_plan So, instead of: A. Check framework changes 1/ In a UNIMARC k-t-d or sandbox, with Zebra search engine 2/ Apply the patch 3/ Check default and FA framework - 099 should be labelled "Local dates (Koha)" and contain 2 subfields:c and d - 942 should be mandatory, labelled "ADDED ENTRY ELEMENTS (Koha)" and contain 5 subfields : 0,2,6,c (mandatory),s 4/ Create a new record with default framework -- add a 200$a field, a 100$a field (with the cataloging plugin) -- in 942$c field, check that the values in dropdown list are the one defines for 'item types' in administration (Books, Computer Files, Continuing Resource, etc). -- Choose the value "Computer field" and Save the record -- Koha displays the item creation form. Check that the preselected value in 995$r (item type) is "Computer field" 5 / Do the same operation for a new record with FA framework Something like this, perhaps? A. Check framework changes 1/ In a UNIMARC k-t-d or sandbox, with Zebra search engine 2/ Apply the patch 3/ Check default and FA framework - 099 should be labelled "Local dates (Koha)" and contain 2 subfields:c and d - 942 should be mandatory, labelled "ADDED ENTRY ELEMENTS (Koha)" and contain 5 subfields : 0,2,6,c (mandatory),s 4/ Create a new record with default framework -- add a 200$a field, a 100$a field (with the cataloging plugin) -- in 942$c field, check that the values in dropdown list are the one defines for 'item types' in administration (Books, Computer Files, Continuing Resource, etc). -- Choose the value "Computer field" and Save the record -- Koha displays the item creation form. Check that the preselected value in 995$r (item type) is "Computer field" 5/ Do the same operation for a new record with FA framework Finally, do you know if there a way to test the changes made to the installer's YAML files? Thank you! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
