https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744
--- Comment #53 from David Gustafsson <[email protected]> --- (In reply to Andrew Fuerste-Henry from comment #47) > (In reply to David Gustafsson from comment #45) > > (In reply to Andrew Fuerste-Henry from comment #41) > > > Small note, the string this puts into the info field isn't formatted > > > exactly > > > like edits of other parts of the patron record. For example, here's an > > > edit > > > to a name field: > > > { "preferred_name" : { "after" : "Huey", "before" : "Hank" } } > > > > > > And an edit to an attribute: > > > Patron attribute SHOW_BCODE: { "after" : "1", "before" : "" } > > > > > > Not a blocker, but worth noting for its impact on reports. > > > > Ok! I changed the log format to pure json, prepending "attribute." to the > > "field" name. Also saw that the normal field logging writes one log entry > > for all field changes, so fixed so this is done also for attribute changes. > > Thanks, David! I can confirm the syntax change looks good and multiple > attribute changes all log as one entry. > Is there some inherent reason attribute changes and edits to the regular > borrower fields couldn't all go in one log line when performed together? If > that's feasible, I may file a followup bug for it. That's not practically possible I'm afraid, even though I can se how it makes sense from a user perspective. as code wise fields and attributes are very different things, with no common methods for updates/changes. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
