https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34070
--- Comment #26 from David Cook <[email protected]> --- (In reply to Jonathan Druart from comment #22) > I don't think this is optimal, I am working on an alternative patch. (In reply to Jonathan Druart from comment #25) > Actually both approaches are compatible I think. I have not tested with > yours and mine, but attaching now to get feedback from you, David. > > If you agree that those patches are good for here I will have another round. I think that the approaches are compatible as well, since we're solving different problems. I like your solution for detecting a failed connection early, and then allowing a graceful fallback to DB processing of background jobs (for workers). I haven't tested it but it looks OK at a glance. (Although I'd "die" in the try{} rather than repeat the code for the the warning and undefing of stomp twice.) In my test, I use the failed connection as an example because it was easy to reproduce, but that's not my primary concern. My concern is the ERROR frames I'm getting for "\"NACK\" must include a valid \"message-id\" header\n". Personally, I don't get the CONNECT problems, but I do sometimes get these odd NACK ones for successful connections. But I haven't been able to reproduce it locally unfortunately. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
