https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39331
David Nind <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Text to go in the| |This fixes changing a release notes| |patron with guarantors from | |a patron category that | |allows guarantees to one | |that doesn't (for example, | |from Kid to a Patron). | |Currently, the guarantor | |relationships are kept | |(when they shouldn't be). --- Comment #5 from David Nind <[email protected]> --- I've signed off, as the patch does what it says it does. However, what is the expected behavour when changing a patron's category from one with a guarantor to one without? Options: 1. Should it silently remove the guarantor? (This is what happens now after the patch, which I assume is the behavour expected before the bug was identified.) 2. Should it display a warning message when attempting to save the patron, asking you to confirm that the guarantor relationship(s) will be removed? 3. Should there be an information message after saving the changes to the patron, saying that the guarantor(s) was removed because the patron category was changed? Or is this outside the scope of this bug? (That is, this bug should restore the current expected behavour (option 1)). Testing notes (using KTD): 1. Go to Koha administration > Patrons and circulation > Patron categories. 2. For the Kid patron category (Code = K, Type = Child): - remove the values in these fields: . Age required . Upper age limit - check that the "Can be guarantee field" is set to "Yes" 3. For the Patron patron category (Code = PT, Type = Adult): - remove the values in these fields: . Age required . Upper age limit - check that the "Can be guarantee field" is set to "No" 4. Add a guarantee to a child patron: - Child patron: Lisa Charles (borrownumber = 37) - Guarantor: Edna Acosta (borrowernumber = 5) 5. Check the database: SELECT * FROM borrower_relationships WHERE guarantee_id=37; Result: +----+--------------+--------------+--------------+ | id | guarantor_id | guarantee_id | relationship | +----+--------------+--------------+--------------+ | 1 | 5 | 37 | mother | +----+--------------+--------------+--------------+ 6. Change Lisa Charles from a Kid patron category to a Patron patron category. Result: Still has a guarantor 7. Repeat step 5. Result: +----+--------------+--------------+--------------+ | id | guarantor_id | guarantee_id | relationship | +----+--------------+--------------+--------------+ | 2 | 5 | 37 | mother | +----+--------------+--------------+--------------+ 8. Note that the relationship still exists, and the id is incremented. What should have happened: the guarantor should have been removed (?) 9. Apply the patch and RESET everything (reset_all). 10. Repeat steps 2 to 7. For the result in step 7, the guarantor relationship is removed: - SQL query (SELECT * FROM borrower_relationships;): Empty set (0.000 sec) - Lisa Charles: No guarantor shown on patron details page - Edna Acosta: No guarantee shown on patron details page 11. Test with removing multiple guarantors: - Change the patron category for Lisa Charles back to Kid - Repeat steps 4 to 7 with these changes: .add TWO guarantors. Result: All guarantors should be removed. 12. Test changing the patron category to a category that can have a guarantee (for example, J - Juvenile): - Change the patron category for Lisa Charles back to Kid - Repeat steps 4 to 7 with these changes: . add TWO guarantors . change the patron category for Lisa Charles from Kid to Juvenile (not Patron) Result: all the guarantors should remain. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
