https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #26 from Katrin Fischer <[email protected]> --- Hm, these patches are from last week, but I get an untidy warning: 0) QA script FAIL installer/data/mysql/atomicupdate/bug_37211.pl FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl installer/data/mysql/atomicupdate/bug_37211.pl` FAIL koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc` Please check your setup! I have seen some of those and would like to get to the bottom of this. it's time consuming to squash into the right patches also. There are also some other small issues: 1) We are missing the permission in the installer file for new installations. (blocker) 2) The permission name is very general with "edit_notes". I think it might pay off to be a bit more specific for people looking at these in reports etc. to give an example. edit_accountlines_notes? (suggestion) 3) The input field for changing/editing the note is quite small. Can we make that a big more generous please? If you need to "scroll" within a longer text field for editing, this leads to errors and grup easily. (kind of blocker) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
