https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604
--- Comment #116 from Katrin Fischer <[email protected]> --- Starting with a first code review (always got to start somewhere :)) 0) QA script I am aware that some might be false positives, but I believe there are some that need fixing as well: FAIL installer/data/mysql/atomicupdate/bug_35604.pl FAIL file permissions File must have the exec flag FAIL installer/data/mysql/mandatory/sysprefs.sql FAIL semicolon simicolon found instead of comma at line 879 FAIL koha-tmpl/intranet-tmpl/prog/js/ill-autobackend.js FAIL forbidden patterns forbidden pattern: console.log (line 68) FAIL koha-tmpl/opac-tmpl/bootstrap/js/ill-autobackend.js FAIL forbidden patterns forbidden pattern: console.log (line 68) FAIL t/db_dependent/Koha/ILL/Backends.t FAIL file permissions File must have the exec flag FAIL t/db_dependent/Koha/ILL/Request/Workflow/ConfirmAuto.t FAIL file permissions File must have the exec flag 1) Koha/ILL/Request/Workflow/ConfirmAuto.pm From the code comments this looks like display components handled in a module? Maybe we can talk things through a bit, when I got a little deeper into the feature set. 2) Tiny typo + description => "Add new AutoILLBackendPriority system preferences", We only add one :) 3) System preference - Availability checking is mentioned the first time in the pref description, but not in other places. - type is given as ILLBackends in kohastructure.sql, but as ill-backends in the yaml. If I understand correctly the preference won't work with only Standard. You need at least 2 backends installed and you need the availability check plugin/capability implemented in backend for these, is that correct? 4) Capitalization a) + <li>Make an automatic <a href="/cgi-bin/koha/opac-illrequests.pl?op=create&backend=Standard">Interlibrary loan request</a></li> Also wrong in the old part of the code: <li>Make an <a href="/cgi-bin/koha/opac-illrequests.pl?op=create">Interlibrary loan request</a></li> 5) Translatability + let message = "Error"; -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
