http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10464
--- Comment #6 from Katrin Fischer <[email protected]> --- Created attachment 19042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19042&action=edit [PASSED QA] Bug 10464 - Patron search on placing a hold should provide autocomplete We should provide the autocomplete feature, already present for the circulation search box, if CircAutocompl is properly set; and leave as it currently works otherwise of course. This patch grabs the autocomplete handling javascript stuff from patron-search-box.inc and puts an adjusted version on reserve/request.tt and also adjusts form and input id's to match those configured in the autocomplete call. This changes where needed due to name collisions with the patron-search-box.inc that is present everywhere. To test: - On a biblio record, go to the Holds tab, mine looks like /cgi-bin/koha/reserve/request.pl?biblionumber=2 - A search box is shown for patron searching. - Search for a patron: it works as usual. - Make sure CircAutocompl is 'Don\'t try' - Apply the patch - Click the Holds tab again, and do the same search: functionality should remain intact. - Change CircAutocompl to 'Try' - Click the Holds tab again - Autocomplete should show you the possible options, and once you choose one result, it should work as usual. Note: once you apply the patch the width of the search input field will be doubled. If you are oleonard and prefer to stick with size=20, please amend the patch, I just prefered how it looked at size=40. Regards To+ Edit: Wrapped the JavaScript code with [% UNLESS ( borrowernumber || borrower_list ) %] to fix the behaviour on the case of rendering the placing hold page instead. Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Kyle M Hall <[email protected]> Signed-off-by: Katrin Fischer <[email protected]> Passes all tests and QA script. Adding a nice new autocomplete feature. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
