https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39498
Bug ID: 39498
Summary: Correct display of patron restriction comments
Change sponsored?: ---
Product: Koha
Version: Main
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: Patrons
Assignee: [email protected]
Reporter: [email protected]
QA Contact: [email protected]
CC: [email protected], [email protected]
In Bug 31097, we introduced the possibility to show display of patron
restriction types and expiry dates directly in the patron's account in
checkouts and in details. (And to the display in the OPAC)
The way it is currently, if a patron has many restrictions but only on one of
them they have a comment on the restriction, the text "with the explanation:"
is shown for each restriction, even those with no comments. This looks not
right.
The text should only be shown for the one restriction that has a comment and
not for the others.
This is because we are checking if "debarredcomment" exists. But
"debarredcomment" is filled as soon as any one restriction has a comment. So it
will be true even for other restrictions that have no comment as long as they
are on the same patron account as one that has a comment.
Instead we should be checking inside the FOREACH loop for every restriction, if
it has restriction.comment filled, and only display the text if that is true
for that specific restriction.
Also, if you add a restriction with a comment containing the text
"OVERDUES_PROCESS" (or more likely if such a restriction is set automatically
during overdues process), all other restrictions are no longer displayed.
This is because the overdues check again happens before the FOREACH loop. Again
it should be inside the loop so it only displays for the Overdues restrictions
and does not block other restrictions from also being shown.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
