https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39410
Lucas Gass (lukeg) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180065|0 |1 is obsolete| | --- Comment #3 from Lucas Gass (lukeg) <[email protected]> --- Created attachment 180274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180274&action=edit Bug 39410: Use shadowDOM for notice display modal This patch updates the notice display modal found in the members > notices page to use a shadowDOM to more accurately display notices matching how they should display for patrons in their email clients or when printed. Test plan 1) We can use the 'WELCOME' print notice introduced in bug 38087 as it includes Bootstrap classes for display. 2) Navigate to the 'Henry' user in KTD and use the 'More > Send welcome notice' option to trigger a print notice. 3) Navigate to the 'Notices' tab for the 'Henry' user and click on the notice title to trigger the display modal. 4) Note the well formatted notice with an address block on the right and some sections in bold. 5) Apply this patchset 6) Display the notice again as in step 3 and note that the foratting is now lost. This is showing proper scoping of the CSS in the same way that the notice will be displayed to the end user when printed using batch printing. Note: Whilst this degrades the look of the notice in the staff client, that is actualy highlighting a mistake in the notice template or possible showing that we should be including bootstrap in the print notices template... that is for another bug. Signed-off-by: Brendan Gallagher <[email protected]> Signed-off-by: Lucas Gass <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
