https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37020
--- Comment #23 from Thomas Klausner <[email protected]> --- Review of the patch "Bug 37020: [alternate] Changed script to use XML:Twig to reduce memory usage.": This patch changes a lot, mainly using XML::Twig to pull-parse the (huge) XML file instead of using the regex-"parser" in MARC::Batch. It is a bit hard to read because it adds some comments (which would have to be removed) and adds a bunch of functions before the main code (which IMO is bad style, but maybe OK for Koha?), also moving the helper funtion up in the code. It proposes two different parsers, one removing the namespaces ('marc:record'), one not. Not sure why we need this. I like that processing a record is moved into a function. So I guess if this approach is taken, the code layout should be changed to have all the functions AFTER the main code, and we need to decide which of the two parser-function should be used (or we have both and a flag to choose?) I like this approach better then the other one because it removes MARC::Batch (for reading XML) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
