https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978

Amaury GAU <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #179890|0                           |1
        is obsolete|                            |

--- Comment #33 from Amaury GAU <[email protected]> ---
Created attachment 180587
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180587&action=edit
Bug 34978: (QA follow-up) Simplify code and make it stricter

This patch simplifies the code a bit, removing duplicated pieces of code
and making it slightly more readable.

The main change is that it now just filters the `@plugin_classes` list
as required, and leaves the original codebase for dealing with loading
the plugins untouched.

A BIG change it implements is that it now requires full class names. I
don't see the use case for partial names, and I generally think we
should be stricter in this area. If there's the need for partial class
names, this should be handled with specific parameters, etc.

It also makes it explicit that the `include` and `exclude` parameters
are mutually exclusive.

A minor idiomatic issue is fixed as well.

Signed-off-by: Tomas Cohen Arazi <[email protected]>
Signed-off-by: Hammat Wele <[email protected]>
Signed-off-by: Amaury GAU <[email protected]>

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to