https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39435
--- Comment #24 from David Cook <[email protected]> --- Thanks for tidying things up. It makes it easier to read for sure. Some feedback: 1. I like the DB revision. That is clever. 2. I'll want to review Koha::BotChallenger and opac/opac-bot-challenge.pl in more depth at a later date... 3. Why add BotChallenger to C4::Auth and opac-export? 4. The circular redefinition stuff is because you're using it in C4::Auth. Since you're using Koha::BotChallenger->new anyway, you could move those from being constants to being variables in new(). I don't think that would have any real negative implications. -- Some more ideas: 1. What about implementing this as a Plack middleware like in bug 39109? I haven't done that with my local version, but I've been thinking about rewriting it to be a Plack middleware. (I suppose the problem with that is that it won't work for people not using Plack, which we've noticed with the anti-CSRF stuff, but I think we mandate Plack anyway... so not really a problem.) 2. When I suggested the plugin idea, I was actually meaning more so for the business logic of identifying bots and presenting them with a more standard page. Locally, I've created an "opac-challenge.tt" which is part of Koha and is thus translatable. That said, it is using C4::Template to have the best UX. In terms of performance, I haven't let the bots hit it yet, so I can't make any guarantees on server impact. However, I have an idea for that too. I think we should consider creating a static page built using C4::Template so that it has a good human UX while still being low/no impact. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
