https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17338
Brendan Lawlor <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #15 from Brendan Lawlor <[email protected]> --- Thanks for working on this Lucas. This works when the action button says 'Cancel hold', but if the button says 'Cancel and return to: [library]' then when you click the 'OK' button it returns you to the first tab 'Holds waiting' To recreate you need to have some more holds that can be fulfilled at your branch and other branches when you cancel a hold that's waiting past its expiration date. I think these other two forms cancelReservewithtransfert and cancelReservewithwaiting just need to pass the tab param and adjust their action attribute a bit. The anchor in the action url waitingreserves.pl#holdsover_panel does not load the tab, but as a parameter waitingreserves.pl?tab=holdsover_panel loads the correct tab. For example this works when a transfer is triggered: <form name="cancelReservewithtransfert" action="waitingreserves.pl" method="get"> <button type="submit" class="btn btn-default approve"><i class="fa fa-fw fa-check"></i> OK</button> <input type="hidden" name="tab" value="[% tab | html %]" /> </form> The other question I have is on waiting reserves.pl from line 47: if ( $item && $tab eq 'holdsover' && !@cancel_result ) { print $input->redirect("/cgi-bin/koha/circ/waitingreserves.pl#holdsover"); } elsif ( $op eq 'cud-cancelall' ) { print $input->redirect("/cgi-bin/koha/circ/waitingreserves.pl"); } I think this needs some work because now tab will be holdsover_panel, and also the redirect no longer seems to need the anchor in the url. Could this now be combined? While testing another bug I noticed is that when cancelling the hold triggers a transfer, the library's name does not render in the alert: line 57: <h2>This item is on hold for pick-up at [% Branches.GetName( branchname ) | html %]</h2> That should be written as [% Branches.GetName( branchcode ) | html %] I filed that bug 39569 and will post a patch soon. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
