https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37020
--- Comment #37 from David Gustafsson <[email protected]> --- (In reply to Thomas Klausner from comment #35) > @David Gustafsson: I also mentioned all of this in my previous comments. And > I still think we should move away from MARC::Batch and use XML::LibXML. And > I also liked the cleanups Leo Stoyanov did in his XML::Twig version. > > I'm in a train with very flaky internet at the moment, so it's a bit hard to > review your patch (because of all the indention changes..), but at the first > glance it seems very similar to Kyle M Halls patch? > > So I don't think we should just go with the minimal fix, but properly > improve bulkmarcimport. > > What do you think of my analysis in the comments prior to your commits? > > I would have loved a bit of discussion / feedback... I have had a look at the XML::Twig patch and now that the records are again streamed and not loaded all at once I don't see why we should add a new dependency and increase code complexity with very little to gain in terms of memory consumption. I may be wrong, but memory consumbed by XML::LibXML should be released a record has been read, so there should not really be any significant difference. With regard to the patch by Kyle M there is a bug introduced where the main loop can be terminated without indexing the last batch of records, since the conditions for indexing the last batch will not be met. There needs to be an additional check for if we have run out of records, and after that a check whether to terminate the loop. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
