https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39624
David Nind <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the "Default release notes| |open article requests | |limit" for the circulation | |and fine rules, so that the | |patron category dropdown | |list now includes an "All" | |option. | | | |Previously, there | |was no "All" patron | |category option, and you | |needed to set rules | |individually for each | |patron category. | | | |(This | |requires the | |ArticleRequests system | |preference enabled.) Summary|Add |Add an "All" patron |open_article_requests_limit |category option for the |for patron category 'All' |"Default open article | |requests limit" circulation | |rules Status|Needs Signoff |Failed QA --- Comment #4 from David Nind <[email protected]> --- I have Failed QA. With the patch applied, you cannot delete the "All" rule: 1. If you attempt to delete the "All" rule: the page refreshes, but the rule is still there. 2. It works correctly before the patch for individual patron category rules. 3. It still works correctly after the patch for individual patron category rules. 4. It does not work after the patch for the "All" rule. In addition, both before and after the patch, when cancelling article requests using the staff interface, a progress spinner is displayed (this should probably be a separate bug): 1. Place some article requests 2. Go to Circulation > Patron request > Article requests 3. Select a request and use either the "Cancel request" option in the action column or the "Actions > Cancel request" button next to the filters 4. Note that a progress spinner is displayed, and the page does not refresh 5. If you refresh the page (or click the sidebar menu), the cancelled request is no longer shown Testing notes (using KTD): 1. Enable the ArticleRequests system preference (without this, you cannot see the settings for "Default open article requests limit" in step 3. 2. Go to Koha administration > Patrons and circulation > Circulation and fine rules. 3. Go to the section on the page with the heading "Default open article requests limit". 4. Note that for the dropdown list for "Patron category" there is no "All" option. 5. Apply the patch. 6. Repeat steps 3 and 4 and note that there is now an "All" option. 7. Test that the "All" limit works as expected: 7.1 Add an "All" limit for article requests: - Patron category: select "All" (the default) - Total article requests: enter "2" - Click "+ Add" 7.2 Place multiple requests in the OPAC, for example on record 5, Perl best practices, for a patron (I used the koha user): - Once the limit is exceeded (on your third request) you should get a message "You reached your open article requests limit." 8. Test that the "All" limit and a different limit for another patron category works as expected: 8.1 Cancel all the requests already placed 8.2 Add a limit for another patron category, I used "Staff" - Patron category: select "Staff" - Total article requests: enter "1" - Click "+ Add" (We now have two rules - All = 2, Staff = 1) 8.3 As the koha user, attempt to place 2 holds: ==> On the second request you should get the message "You reached your open article requests limit." 8.4 As another user in any patron category except "Staff", attempt to place 3 holds (you will need to change the password so you can log in to the OPAC, I used Mary Burton): ==> On the third request you should get the message "You reached your open article requests limit." -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
